test(replay): [Data Collection 16] Keep Replay independent - #5832
Draft
adinauer wants to merge 8 commits into
Draft
test(replay): [Data Collection 16] Keep Replay independent#5832adinauer wants to merge 8 commits into
adinauer wants to merge 8 commits into
Conversation
Let nullable Session Replay network options inherit matching Data Collection settings while preserving historical Replay defaults when Data Collection is absent. Keep explicit Replay options authoritative and apply the effective policies to OkHttp network details. Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Jul 24, 2026
adinauer
commented
Jul 24, 2026
📲 Install BuildsAndroid
|
Contributor
Performance metrics 🚀
|
This was referenced Jul 24, 2026
…-collection-session-replay-network-options
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
…-collection-session-replay-network-options
9 tasks
9 tasks
9 tasks
…-collection-session-replay-network-options
…-collection-session-replay-network-options
…-collection-session-replay-network-options
Restore Session Replay network privacy settings as the only controls for Replay data. Data Collection and sendDefaultPii do not affect Replay, which avoids changing behavior for existing Replay users. Add coverage that restrictive Data Collection settings leave explicitly enabled Replay network details unchanged. Refs #5666 Co-Authored-By: Claude <noreply@anthropic.com>
Member
Author
|
After checking with other teams, we're aligning with JS SDK which is currently not applying Data Collection options to Session Replay. Similar to JS SDK, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Data Collection)
📜 Description
Keep Session Replay network privacy settings independent from Data Collection.
Add regression coverage proving that restrictive Data Collection body and header settings do not affect explicitly enabled Replay network details. Replay continues to use its existing URL allow/deny lists, body capture option, and request/response header allow lists.
💡 Motivation and Context
sendDefaultPiihas no effect on Session Replay today. Wiring Data Collection into Replay would introduce new behavior and combine controls with opposing defaults: Replay network details are opt-in through URL allow lists, while Data Collection uses its own defaults for supported integrations.Keeping the features independent avoids privacy-sensitive behavior changes for existing Replay users. The Data Collection documentation will call out that Replay remains governed by Replay-specific options.
Refs #5666
💚 How did you test it?
./gradlew :sentry-okhttp:test --tests='io.sentry.okhttp.SentryOkHttpInterceptorTest'./gradlew spotlessApply apiDumpgit diff --check📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Document that Session Replay is not controlled by Data Collection and continues to use Replay-specific privacy options.
#skip-changelog